ChronosXYZ/signaller
1
0
Fork 0
mirror of https://github.com/signaller-matrix/signaller.git synced 2024-11-21 18:02:24 +00:00
Code Issues Projects Releases Wiki Activity

Fix SetTopic mutex infinity lock

Browse Source
This commit is contained in:
nxshock 2019-08-08 20:02:46 +05:00
parent f8c6a259e2
commit 4fc26f127e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/backends/memory/user.go
View File

@ -114,14 +114,16 @@ func (user *User) SetTopic(room internal.Room, topic string) models.ApiError {
memRoom := room.(*Room) memRoom := room.(*Room)
memRoom.mutex.Lock() memRoom.mutex.Lock()
defer memRoom.mutex.Unlock()
if memRoom.creator.ID() != user.ID() { // TODO: currently only creator can change topic if memRoom.creator.ID() != user.ID() { // TODO: currently only creator can change topic
memRoom.mutex.Unlock()
return models.NewError(models.M_FORBIDDEN, "") return models.NewError(models.M_FORBIDDEN, "")
} }
memRoom.topic = topic memRoom.topic = topic
memRoom.mutex.Unlock()
rEvent := &RoomEvent{ rEvent := &RoomEvent{
Type: rooms.Topic, Type: rooms.Topic,
Sender: user, Sender: user,